Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests for the Xiaomi Air Conditioning Companion #182

Merged

Conversation

syssi
Copy link
Collaborator

@syssi syssi commented Jan 26, 2018

No description provided.

self.device._reset_state()
self.device.state[1] = None
assert self.state().fan_speed is None

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blank line at end of file

@coveralls
Copy link

coveralls commented Jan 26, 2018

Coverage Status

Coverage increased (+1.2%) to 63.979% when pulling 36abfa5 on syssi:feature/pytests-airconditioningcompanion into e9ce9e0 on rytilahti:master.

configuration = configuration.replace('[wi]', fan_speed.value)
configuration = configuration.replace('[sw]', swing_mode.value)
configuration = configuration.replace('[po]', str(power.value))
configuration = configuration.replace('[mo]', str(operation_mode.value))

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

line too long (80 > 79 characters)

@@ -48,7 +48,7 @@ class Power(enum.Enum):
},
'0100010727': {
'deviceType': 'gree_2',
'base': '[po][mo][wi][sw][tt]1100190[tt1]205002102000t7t0190[tt1]207002000000[tt4]0',
'base': '[po][mo][wi][sw][tt]1100190[tt1]205002102000[tt7]0190[tt1]207002000000[tt4]0',

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

line too long (95 > 79 characters)

configuration = configuration.replace('[wi]', fan_speed.value)
configuration = configuration.replace('[sw]', swing_mode.value)
configuration = configuration.replace('[po]', str(power.value))
configuration = configuration.replace('[mo]', str(operation_mode.value))

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

line too long (80 > 79 characters)

@@ -48,7 +48,7 @@ class Power(enum.Enum):
},
'0100010727': {
'deviceType': 'gree_2',
'base': '[po][mo][wi][sw][tt]1100190[tt1]205002102000t7t0190[tt1]207002000000[tt4]0',
'base': '[po][mo][wi][sw][tt]1100190[tt1]205002102000[tt7]0190[tt1]207002000000[tt4]0',

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

line too long (95 > 79 characters)

@syssi syssi assigned syssi and unassigned syssi Jan 26, 2018
@syssi syssi requested a review from rytilahti January 26, 2018 17:28
@syssi
Copy link
Collaborator Author

syssi commented Jan 26, 2018

The tests are very basic but they are useful nevertheless. I would by happy about a quick merge because of the fixed bug.

@rytilahti
Copy link
Owner

Looks good, let's merge and deliver a release this weekend!

@rytilahti rytilahti merged commit b281845 into rytilahti:master Jan 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants